fix: Vertically Align Navbar Items with Brand Name #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Teja-11
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12 +/- ##
==========================================
+ Coverage 94.03% 94.30% +0.26%
==========================================
Files 9 9
Lines 151 158 +7
==========================================
+ Hits 142 149 +7
Misses 9 9 ☔ View full report in Codecov by Sentry. |
Niloth-p
reviewed
Nov 15, 2023
There was a problem hiding this comment.
No visible changes to the vertical alignment.
The alignment issue most probably has to do with the hierarchy of elements with bootstrap classes, not their styling. Also, it's not a good idea to use inline styles to override a lot of the bootstrap styling this way.
|
I'll be adding more modular issues in a couple of weeks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses a layout issue in the header navigation where the navbar items were not aligned vertically with the brand name. By applying inline CSS styles, we ensure that the navbar-toggler, navbar-brand, and navbar-collapse are centered along the same line, improving the visual coherence of the header. The implemented changes use flexbox to align items centrally and apply auto margins to manage spacing, making the header appear more structured and aesthetically pleasing across various screen sizes.